If the President should be impeached really depends on party affiliation, that is how it seems.
Furthermore, does the president need to commit pre-established crimes to be impeached, or can the majority of Congress determine if the actions or attempted potential actions are impeachable, also depends on the party affiliation, as democrats will argue that this satisfies the criteria vs republicans that will argue that it does not meet the criteria for impeachment. (some will even argue that what the president did was good and his concerns were legitimate).
I believe the same actually happened during the Clinton impeachment, despite president Clinton actually committing pre-established crimes.
All of this feeds the press, it creates narratives. Democrats hope this will feed their narrative against Trump, Republicans believe that this will expose democrats, or as they call it “the swamp” and reenergize republican voters come 2020.
I guess time will tell.