The two things I see as being crucial to a stellar cholent is:
Flanken, with loads of fat on them
Kishka (the store bought kind)
All the other things (onions, fried or not, coke, beer, ect) are up to your personal preference.
But the fat content of the flanken / kishka is what wins the prize (dieters get a free pass on Shabbos)