A “lawyer” would never be a shailoh. All a lawyer is, be definition, is someone with expertise in how a legal system (or systems) work who gives people advice on dealing with the legal system. Given that one often deals with legal systems, that is a useful skill. If you are inclinced to help evil people do more evil, it is a great opportunity to make money by going off the derekh. However knowing about the legal systems we deal with is not an issue. A “judge”, especially in Medinat Yisrael, would be a serious shailoh, especially if one holds the medinah to have any halachic status since if you hold that Medinat Yisrael is a Jewish state (as opposed to a goyish state with many Jews living there), there is a problem since its legal system is totally not based on Jewish law and on most matters works contrary to halacha. One should also remember that have a just legal system is one of the mitsvos of the Bnei Noach.
If you think going to a law school is a meal ticket to great riches you should stay in yeshiva until you become cleverer and more mature. Even under ideal conditions, a degree from a top law school (in New York City, that would be NYU and Columbia) didn’t guarantee you anything. Remember that the better law schools are much more expensive that the rest. Also if one plans to do something other than “big law” (such as hang out a shingle in a frum community, helping your neighbors with their legal issues) going to a name law school isn’t worth the extra cost. If you want to be a lawyer, go to law school. If you want to get rich, review the halachic definition of who is rich (its in Pirke Avos).