Sparkly- In the 1940s and 50s cigarettes were a form of currency in many parts of the world. It was only in the 60s that we started to hear that smoking was hazardous. Many Rosh Yeshivas smoked up until the 1980s and I tend to doubt they were OTD.
You state “my guy will probably not smoke” does this mean you can’t tell if he smokes or not through either sight or smell. Or does it mean that you really don’t care. Are girls either totally against it or fine with it, why can’t they possibly want and or hope he will quit smoking and think they can convince him to do it.
As for as most of the smokers in your community are OTD. Many smokers in the MO community are rebelling against society and therefor are also rebelling against G-d. There are underlining factors that have to be analyzed before you can get him/her to quit. You are trying to project this onto All Frum smokers. This is like me saying since most of the MOs who come to the Mincha minyan that I go to, learn the Daf ALL MOS learn the Daf. Which I know is not true. MO who take time from their busy day to daven Mincha with a minyan at work are more devoted and more likely to learn the daf.
I.M. Shufilin There is a limit to what Yeshivas can do. It is the parent’s responsibility to know who their children are associating with as many start due to peer pressure. As I previously said they are rebelling against society if you crack down too hard you run the risk of them going OTD. Be careful around Purim this is when many boys start smoking and drinking.