Sometimes it’s necessary, sometimes it’s a waste of money. It goes both ways. I personally know many people for whom the yeshiva/seminary Israel experience turned their life literally from black to white (for many different reasons: social, religious, clarity).
Every person needs something different. If you don’t think it’s in the best interest of your kids, by all means don’t send them. But don’t ask why others send their children.