He is both. We really do not know for a certainty what his motives were, but if he sold secrets to China, they cannot be too pure, can they? OTOH, he revealed things to us that we had a right know, at least in part.
Maybe people will think twice before posting their entire private lives on Facebook, Twitter, text messaging, etc. It was wrong for our enemies to be alerted to this truth about our country eavesdropping on EVERYONE, but I believe it violates our rights as ordained by the Constitution.